Skip to content

In templates, remove "lstrip('/')" from full node name#65

Open
Rezenders wants to merge 1 commit into
ipa320:mainfrom
Rezenders:drop_left_slash
Open

In templates, remove "lstrip('/')" from full node name#65
Rezenders wants to merge 1 commit into
ipa320:mainfrom
Rezenders:drop_left_slash

Conversation

@Rezenders
Copy link
Copy Markdown

In the current version, the model generation removes the leading slash (the leftmost one), which is fine for nodes that don't contain any slashes in its name, but for nodes containing slashes, such as, /mavros/mavros, /mavros/cmd etc the .ros2 DSL checkers complain.

I get these 2 errors:

Description	Resource	Path	Location	Type
The required feature 'name' of 'ros.impl.NodeImpl@67384d19{platform:/resource/suave_rebetmc/models/ros/mavros__mavros_router.ros2#//@artifact.0/@node}' must be set	mavros__mavros_router.ros2	

Invalid token mavros/mavros_router mavros__mavros_router.ros2	/suave_rebetmc/models/ros	line 4	Ros2 Problem

Adding a leading slash solves the problem. The issue is only with the .ros2 DSL but I also made the same change to the .rossystem DSL to make it consistent. Not sure if this should be fixed/changed in RosTooling itself or only in the generation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant